Skip to content

fix: remove crd-generator-api dependencies #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2022
Merged

fix: remove crd-generator-api dependencies #1439

merged 4 commits into from
Sep 2, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 2, 2022

No description provided.

@csviri csviri self-assigned this Sep 2, 2022
@csviri csviri changed the title Crd generator fix fix: remove crd-generator-api dependencies Sep 2, 2022
@csviri
Copy link
Collaborator Author

csviri commented Sep 2, 2022

to be merged after: #1436

@csviri csviri requested a review from metacosm September 2, 2022 08:45
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either needs to be rebased on done instead of #1436 but otherwise, LGTM

@csviri csviri marked this pull request as ready for review September 2, 2022 08:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

61.0% 61.0% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit 4e15248 into next Sep 2, 2022
@csviri csviri deleted the crd-generator-fix branch September 2, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove crd-generator-api Dependency After CRD Generator Fix in Fabric8 Client
2 participants